Repository navigation
Conversation
The test-ios-rntester, test-ios-helloworld actions and the test_android_helloworld job unconditionally run use-hermes-nightly.js, which replaces the pinned Hermes version with the latest nightly from npm. On stable/release branches this is wrong: the pinned version from version.properties should be used instead. Add a `use-hermes-nightly` input (default true for backward compat) to both composite actions, and guard the nightly override steps behind it. In test-all.yml, pass `!endsWith(github.ref_name, '-stable')` so that pushes to *-stable branches use the pinned Hermes version.
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as #56582, rebased onto main.
The
test-ios-rntester,test-ios-helloworldcomposite actions and the inlinetest_android_helloworldjob unconditionally runuse-hermes-nightly.js, overriding the pinned Hermes version with the latest npm nightly. On-stablebranches, this causes linker failures when the nightly Hermes has ABI-incompatible changes (as happened with0.17.0-commitly-202604221946).The
prebuild-ios-coreworkflow already correctly gates this behind ause-hermes-nightlyinput. This PR applies the same pattern everywhere else.Also adds the guard to
test_ios_rntester_dynamic_frameworkswhich exists on main but not on 0.83.Changelog
[Internal]
Test Plan
CI on a
-stablebranch should use the pinned Hermes version fromversion.propertiesinstead of the nightly.