Repository navigation
Conversation
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D126472293. |
Collaborator
|
This pull request was successfully merged by @mrousavy in c7429b0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Importing
RCTMultipartDataTask.handRCTHTTPRequestHandler.hproduces nullability-completeness warnings because the headers mix annotated return values with unannotated pointers and blocks.Complete the annotations with
NS_ASSUME_NONNULL, keeping optional configuration providers, interceptors, progress handlers and multipart callback payloads nullable. This matches the existing implementations, including clearing an interceptor withniland reporting a failed multipart response without headers or content.Changelog:
[IOS] [FIXED] - Fix missing nullability annotations in networking headers.
Test Plan:
-Werror. Passed in Objective-C and Objective-C++ modes. It also exercises clearing all three providers/interceptors withnil, returningnilfrom each interceptor, nullable multipart callback payloads and an absent progress callback.-Wnullability-completenesserrors.RCTMultipartDataTask.mwith-fsyntax-only -Werror=nullability-completenessagainst the same SDK. Passed.--dry-run --Werror) and rangit diff --check. Passed.A full RNTester build was not run for this header-only change.