Repository navigation
Include window unsafe overlap in view inset events - #59243
Open
Abbondanzo wants to merge 1 commit into
Open
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: Correct experimental safe-area inset events for views extending beyond an already-inset native parent. Preserve UIKit's own insets and augment each physical edge only where the view's rendered bounds intersect an unsafe strip of its owning window. Report the added distances in window points, preserving equal measurements for equal rendered bounds after scaling or reflection. Do not treat off-window space on an unreserved edge as system coverage. Keep the existing layout-pass dispatch, threshold suppression and synchronous callback behavior. Standard UIKit `safeAreaInsets` is unchanged; no new public API. Changelog: [iOS][Fixed] - Correct experimental safe-area inset events for overflowing child views Differential Revision: D126122349
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126122349. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Correct experimental safe-area inset events for views extending beyond an already-inset native parent. Preserve UIKit's own insets and augment each physical edge only where the view's rendered bounds intersect an unsafe strip of its owning window. Report the added distances in window points, preserving equal measurements for equal rendered bounds after scaling or reflection. Do not treat off-window space on an unreserved edge as system coverage.
Keep the existing layout-pass dispatch, threshold suppression and synchronous callback behavior. Standard UIKit
safeAreaInsetsis unchanged; no new public API.Changelog:
[iOS][Fixed] - Correct experimental safe-area inset events for overflowing child views
Differential Revision: D126122349