Skip to content

fix(touch-selection): don't ignore .cm-content in pointer target filter - #1894

Merged
bajrangCoder merged 1 commit into
Acode-Foundation:mainfrom
bajrangCoder:fix/cm-content-native-selection-regression
Feb 21, 2026
Merged

bajrangCoder merged 1 commit into
Acode-Foundation:mainfrom
bajrangCoder:fix/cm-content-native-selection-regression

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixed touch selection behavior by preventing the CodeMirror editor surface (.cm-content) from being ignored as a pointer target. The fix addresses an issue where .cm-content has the contenteditable attribute, which was causing it to be filtered out by the generic [contenteditable] selector, preventing touch interactions from working correctly on the editor surface.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a targeted bug fix with clear logic: it explicitly checks for .cm-content elements and returns false (don't ignore) when they belong to the CodeMirror view, preventing them from being incorrectly filtered out by the generic [contenteditable] selector. The fix is well-placed in the filtering logic and includes a clear comment explaining the intent.
  • No files require special attention

Important Files Changed

Filename Overview
src/cm/touchSelectionMenu.js Added check to prevent ignoring .cm-content as a pointer target, fixing touch selection on CodeMirror editor surface

Last reviewed commit: 6a49824

@bajrangCoder
bajrangCoder merged commit 3d80ce5 into Acode-Foundation:main Feb 21, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Feb 21, 2026
@bajrangCoder
bajrangCoder deleted the fix/cm-content-native-selection-regression branch February 21, 2026 15:59
7HR4IZ3 pushed a commit to cyber-sight/Acode that referenced this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant