After user chooses "Quit" and allows Bitmessage to wait till sync is done, app can only be stopped via "kill" #1298

Activity

1. stayen

   changed the title [-]After user chooses "Quit" and allows Bitmesasge to wait till sync is done, app can only be stopped via "kill"[/-] [+]After user chooses "Quit" and allows Bitmessage to wait till sync is done, app can only be stopped via "kill"[/+] on Jul 5, 2018
2. PeterSurda

   assigned

   g1itch

   on Jul 6, 2018
3. PeterSurda

   added

   bugSomething isn't working as it's supposed toSomething isn't working as it's supposed to

   on Jul 6, 2018
4. g1itch commented on Jul 6, 2018

   

   g1itch

   on Jul 6, 2018

   Collaborator

   More actions

   What if I often have a couple of dozen objects to be synced? This expression will wait forever: __init__.py#L2764.
5. g1itch commented on Jul 6, 2018

   

   g1itch

   on Jul 6, 2018

   Collaborator

   More actions

   We can use something like

   diff --git a/src/bitmessageqt/__init__.py b/src/bitmessageqt/__init__.py
   index 5e4c18fd..6c7b2e7e 100644
   --- a/src/bitmessageqt/__init__.py
   +++ b/src/bitmessageqt/__init__.py
   @@ -627,8 +627,8 @@ class MyForm(settingsmixin.SMainWindow):
            self.replyFromTab = None
    
            # so that quit won't loop
   -        self.quitAccepted = False
   -        
   +        self.quitAccepted = self.wait = False
   +
            self.init_file_menu()
            self.init_inbox_popup_menu()
            self.init_identities_popup_menu()
   @@ -2703,7 +2703,7 @@ class MyForm(settingsmixin.SMainWindow):
                return
            '''
    
   -        if self.quitAccepted:
   +        if self.quitAccepted and not self.wait:
                return
    
            self.show()
   @@ -2731,7 +2731,7 @@ class MyForm(settingsmixin.SMainWindow):
                        _translate("MainWindow", "Bitmessage hasn't synchronised with the network, %n object(s) to be downloaded. If you quit now, it may cause delivery delays. Wait until the synchronisation finishes?", None, QtCore.QCoreApplication.CodecForTr, pendingDownload()),
                        QtGui.QMessageBox.Yes|QtGui.QMessageBox.No|QtGui.QMessageBox.Cancel, QtGui.QMessageBox.Cancel)
                if reply == QtGui.QMessageBox.Yes:
   -                waitForSync = True
   +                self.wait = waitForSync = True
                elif reply == QtGui.QMessageBox.Cancel:
                    return
    
   @@ -2741,7 +2741,7 @@ class MyForm(settingsmixin.SMainWindow):
                        _translate("MainWindow", "Bitmessage isn't connected to the network. If you quit now, it may cause delivery delays. Wait until connected and the synchronisation finishes?"),
                        QtGui.QMessageBox.Yes|QtGui.QMessageBox.No|QtGui.QMessageBox.Cancel, QtGui.QMessageBox.Cancel)
                if reply == QtGui.QMessageBox.Yes:
   -                waitForConnection = True
   +                self.wait = waitForConnection = True
                    waitForSync = True
                elif reply == QtGui.QMessageBox.Cancel:
                    return

   to show msgbox again if user selected to wait at first.
6. g1itch

   added

   usability

   on Nov 1, 2018
7. che2116

   added a commit that references this issue on Nov 11, 2018

   Fix issue Bitmessage#1298

   60ba6d4
8. che2116

   added a commit that references this issue on Nov 25, 2018

   Fix issue Bitmessage#1298

   c0d838d
9. PeterSurda

   added this to the v0.6.4 milestone on Aug 27, 2020
10. navjotcis commented on Sep 18, 2020

    

    navjotcis

    on Sep 18, 2020

    Last edited by navjotcis

    Contributor

    More actions

    I am facing the same issue which is posted above here whenever I am starting the app and closing(by pressing quit) it before the connection message shows then it stuck in the process and did not close the app so only user can kill the process for closing or maybe we need to wait for few minutes then it will automatically close.
    and another issue is there if it does not stuck in connection issue then sometimes it stuck in synchronization issue here when the user press quit then app asks to press ok in the popup and when you press ok then app start showing Waiting for finishing synchronization message and the same thing happens it did not close the app no matter how many time you try to close it but it stuck in a loop because there is a condition
    pendingDownload() > 0. so sometimes pendingDownload() method returns large no. which take time to reduce due to that loop call n no. of times so in this case app only close when pendingDownload() method return 0 so I have done some changes which
    makes the process better and then app will not stuck in these conditions.

    diff --git a/src/bitmessageqt/__init__.py b/src/bitmessageqt/__init__.py
    index 2f1a6e7..558e1dd 100644
    --- a/src/bitmessageqt/__init__.py
    +++ b/src/bitmessageqt/__init__.py
    @@ -2719,11 +2719,10 @@ class MyForm(settingsmixin.SMainWindow):
     
             self.updateStatusBar(_translate(
                 "MainWindow", "Shutting down PyBitmessage... %1%").arg(0))
    -
             if waitForConnection:
                 self.updateStatusBar(_translate(
                     "MainWindow", "Waiting for network connection..."))
    -            while state.statusIconColor == 'red':
    +            while state.statusIconColor == 'red' and not self.quitAccepted:
                     time.sleep(0.5)
                     QtCore.QCoreApplication.processEvents(
                         QtCore.QEventLoop.AllEvents, 1000
    @@ -2735,7 +2734,7 @@ class MyForm(settingsmixin.SMainWindow):
             if waitForSync:
                 self.updateStatusBar(_translate(
                     "MainWindow", "Waiting for finishing synchronisation..."))
    -            while pendingDownload() > 0:
    +            while pendingDownload() > 0 and not self.quitAccepted:
                     time.sleep(0.5)
                     QtCore.QCoreApplication.processEvents(
                         QtCore.QEventLoop.AllEvents, 1000
    @@ -2750,7 +2749,7 @@ class MyForm(settingsmixin.SMainWindow):
                     curWorkerQueue = powQueueSize()
                     if curWorkerQueue > maxWorkerQueue:
                         maxWorkerQueue = curWorkerQueue
    -                if curWorkerQueue > 0:
    +                if curWorkerQueue > 0 and not self.quitAccepted:
                         self.updateStatusBar(_translate(
                             "MainWindow", "Waiting for PoW to finish... %1%"
                         ).arg(50 * (maxWorkerQueue - curWorkerQueue) /