checkdeps.py broken #1316

Activity

1. PeterSurda

   added

   bugSomething isn't working as it's supposed toSomething isn't working as it's supposed to

   on Jul 19, 2018
2. g1itch

   added 3 commits that reference this issue on Jul 19, 2018

   Fix exception 'KeyError: None' in checkdeps introduced in e92a85e,

   ...

   This issue will close once commit 2ce965b is merged into the 'v0.6' branch.

   2ce965b

   Fix exception 'KeyError: None' in checkdeps introduced in e92a85e,

   ...

   This issue will close once commit c266e85 is merged into the 'v0.6' branch.

   c266e85

   Fix exception 'KeyError: None' in checkdeps introduced in e92a85e,

   ...

   This issue will close once commit e1d2ead is merged into the 'v0.6' branch.

   e1d2ead
3. PeterSurda

   closed this as completedin e1d2eadon Jul 22, 2018
4. PeterSurda

   reopened this on Jul 22, 2018
5. PeterSurda commented on Jul 22, 2018

   

   PeterSurda

   on Jul 22, 2018

   Last edited by PeterSurda

   MemberAuthor

   More actions

   At least on Debian it's still broken after e1d2ead, haven't tested others.
6. g1itch commented on Jul 22, 2018

   

   g1itch

   on Jul 22, 2018

   Collaborator

   More actions

   Sad
7. PeterSurda commented on Jul 22, 2018

   

   PeterSurda

   on Jul 22, 2018

   MemberAuthor

   More actions

   What OS did you test it on?
8. PeterSurda commented on Jul 22, 2018

   

   PeterSurda

   on Jul 22, 2018

   MemberAuthor

   More actions

   It probably works now with Ubuntu for example, but on Debian this is in the os-releases:

   NAME="Debian GNU/Linux"

   and it looks like that's parsed incorrectly, maybe it should be added to the OS_RELEASE dict.
9. g1itch commented on Jul 22, 2018

   

   g1itch

   on Jul 22, 2018

   Collaborator

   More actions

   @PeterSurda Gentoo/Calculate, Ubuntu:Xenial and Ubuntu:Trusy - on Travis CI.
10. g1itch commented on Jul 22, 2018

    

    g1itch

    on Jul 22, 2018

    Collaborator

    More actions

    wow
11. g1itch commented on Jul 22, 2018

    

    g1itch

    on Jul 22, 2018

    Last edited by g1itch

    Collaborator

    More actions

    I really forgot Debian, excuse me please.
    Possible further changes:

    diff --git a/checkdeps.py b/checkdeps.py
    index f261c924..4115c5a8 100755
    --- a/checkdeps.py
    +++ b/checkdeps.py
    @@ -136,6 +136,8 @@ if prereqs:
     OPSYS = detectOS()
     CMD = PACKAGE_MANAGER[OPSYS] if OPSYS in PACKAGE_MANAGER else 'UNKNOWN_INSTALLER'
     for lhs, rhs in EXTRAS_REQUIRE.items():
    +    if OPSYS is None:
    +        break
         if rhs and any([
             EXTRAS_REQUIRE_DEPS[x][OPSYS]
             for x in rhs
    diff --git a/src/depends.py b/src/depends.py
    index 39f5e759..d284a11b 100755
    --- a/src/depends.py
    +++ b/src/depends.py
    @@ -29,6 +29,7 @@ logger.addHandler(handler)
     logger.setLevel(logging.ERROR)
     
     OS_RELEASE = {
    +    "Debian GNU/Linux".lower(): "Debian",
         "fedora": "Fedora",
         "opensuse": "openSUSE",
         "ubuntu": "Ubuntu",

    Maybe it was my mistake to agree with creation of OS_RELEASE dict.
12. g1itch

    added a commit that references this issue on Jul 30, 2018

    Merge pull request #1326 from g1itch/exceptions

    ...

    40a1474
13. surbhicis

    added a commit that references this issue on Jan 17, 2019

    Fix exception 'KeyError: None' in checkdeps introduced in e92a85e,

    ...

    This issue will close once commit 8fa171c is merged into the 'v0.6' branch.

    8fa171c
14. surbhicis

    added a commit that references this issue on May 9, 2019

    Fix exception 'KeyError: None' in checkdeps introduced in e92a85e,

    ...

    This issue will close once commit e8a6ae3 is merged into the 'v0.6' branch.

    e8a6ae3
15. g1itch commented on Jul 10, 2019

    

    g1itch

    on Jul 10, 2019

    Collaborator

    More actions

    Is this still actual?
16. PeterSurda commented on Jul 10, 2019

    

    PeterSurda

    on Jul 10, 2019

    MemberAuthor

    More actions

    It still has at least one bug (after doing the checks, it doesn't always print "run apt-get blablblah", but I think that's a separate one.
17. g1itch commented on Jul 10, 2019

    

    g1itch

    on Jul 10, 2019

    Collaborator

    More actions

    Perhaps it needs a separate test suit.
18. g1itch

    self-assigned this

    on Jul 10, 2019
19. dimyme commented on Nov 10, 2019

    

    dimyme

    on Nov 10, 2019

    Contributor

    More actions

    checkdeps does not catch all cases and is worded quite terribly with lots of nonsensical ` ] . and such garbage. will do a PR soon. 😭 🏞️ 🇳🇦
20. PeterSurda

    added this to the v0.6.4 milestone on Aug 27, 2020