returning optional<DataNode> from newPath methods #12

Activity

1. syyyr commented on Jul 26, 2023

   

   syyyr

   on Jul 26, 2023

   Last edited by syyyr

   Contributor

   More actions

   Also, we always check for std::nullopt in {DataNode,Context}::newPath

   Not 100% true, we only check for std::nullopt in Context::newPath. DataNode::newPath returns std::nullopt if the CreationOptions::Update flag is used and no new nodes were created.

   The documentation explains the return value, but doesn't mention the flag:

    * @return Returns the first created node. If no nodes were created, returns std::nullopt.
   

   I agree, that the return value doc for DataNode::newPath should mention the flag. As for Context::newPath, AFAIK, it can't return no new nodes. But I'm not sure, maybe it doesn't if you're creating a non-presence container with the Update flag? I don't know, I'd have to test.
2. jktjkt

   added a commit that references this issue on Sep 6, 2024

   CI: temporary pin of libyang to 3.0.18

   ...

   4352191