Skip to content

lyd_diff_tree "escapes" to siblings #2417

Open

Description

@snar

.. when called without flag LYD_DIFF_DEFAULTS on node having LYD_DEFAULT or when called on opaque node.

Root cause: nosiblings is checked only when node comparison completed but it not happens on opaque or LYD_DEFAULT nodes.

Workaround: modify application to not call lyd_diff_tree in such cases. But may be it makes sense to check nosiblings and break instead of continue there ?

Activity

  1. michalvasko commented on Jul 28, 2025

    @michalvasko
    Member

    Changing this for opaque nodes may be okay. But for default nodes it would likely break many use-cases, one often does not even know that there are some default nodes (NP containers) so it could seem that no nodes were traversed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is:questionIssue is actually a question.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions