question about rb_sort_clb #2476

Activity

1. michalvasko commented on Jan 22, 2026

   

   michalvasko

   on Jan 22, 2026

   Last edited by michalvasko

   Member

   More actions

   lyplg_type_sort_enum function sorts the enumeration types from largest to smallest

   Not true, it is sorted based on the enum value, the string name is ignored. All the types should be sorted in ascending order.

   I expect the libyang tree to maintain the original XML order. how should I do this?

   You must then define the list as ordered-by user.
2. michalvasko

   added

   is:questionIssue is actually a question.Issue is actually a question.

   on Jan 22, 2026
3. ExclusiveDY commented on Jan 22, 2026

   

   ExclusiveDY

   on Jan 22, 2026

   Last edited by ExclusiveDY

   Author

   More actions

   Not true, it is sorted based on the enum value, the string name is ignored. All the types should be sorted in ascending order.

   The enumeration type in the example above is defined as follows, but it appears in descending order. Why is this?

     typedef Ctype {
       type enumeration {
         enum "XX" {
           value 1;
         }
         enum "YY" {
           value 2;
         }
     }
   

   You must then define the list as ordered-by user.

   Is there any interface I can set up? Or do I need to implement the sorting method myself?
4. michalvasko commented on Jan 22, 2026

   

   michalvasko

   on Jan 22, 2026

   Member

   More actions

   Why is this?

   Okay, I do not know what you are doing exactly. I have tested it myself, you can try it, too. The data are ordered in ascending order based on the enum value.

   Is there any interface I can set up? Or do I need to implement the sorting method myself?

   You can implement a type plugin for a specific typedef. In it you can define your own sorting callback and sort however you want. That is true for system-ordered lists. If you define a user-ordered list, it will always keep the same order of data that were received from the input.
5. ExclusiveDY commented on Jan 26, 2026

   

   ExclusiveDY

   on Jan 26, 2026

   Author

   More actions

   Okay, I do not know what you are doing exactly. I have tested it myself, you can try it, too. The data are ordered in ascending order based on the enum value.

   The original message is as follows.

   <?xml version='1.0' encoding='UTF-8'?>
   <rpc message-id='' xmlns='urn:ietf:params:xml:ns:netconf:base:1.0'>
     <edit-config>
       <target>
         <running/>
       </target>
       <config>
   		<A xmlns='urn:ietf:params:xml:ns:yang:A'>
   		  <B>
   			<C>
   			  <C-type>XX</C-type>
   			</C>
   			<C>
   			  <C-type>YY</C-type>
   			</C>
   		  </C>
   		</A>
       </config>
     </edit-config>
   </rpc>
   

   My test procedure is as follows:

   ly_in *in = nullptr;
   lyd_node *tree = nullptr;
   lyd_node *ntf = nullptr;
   if (ly_in_new_memory(XMLBUF_TO_STR(xmlBuf), &in) != LY_SUCCESS) {
   .....
    }
   if (lyd_parse_op(ctx, nullptr, in, LYD_XML, options, &tree, &ntf) != LY_SUCCESS) {
   .....
   }
   

   Then I output the ntf tree, and it turned out like this:

     <edit-config>
       <target>
         <running/>
       </target>
       <config>
   		<A xmlns='urn:ietf:params:xml:ns:yang:A'>
   		  <B>
   			<C>
   			  <C-type>YY</C-type>
   			</C>
   			<C>
   			  <C-type>XX</C-type>
   			</C>
   		  </C>
   		</A>
       </config>
     </edit-config>
   

   By the way, I found that the behavior of the lyplg_type_sort_enum interface is inconsistent with the behavior of other sort functions.
   LIBYANG_API_DEF int

   lyplg_type_sort_enum(const struct ly_ctx *UNUSED(ctx), const struct lyd_value *val1,
           const struct lyd_value *val2)
   {
       if (val1->enum_item->value > val2->enum_item->value) {      // this the difference.
           return -1;
       } else if (val1->enum_item->value < val2->enum_item->value) {     // this the difference.
           return 1;
       } else {
           return 0;
       }
   }
   
   LIBYANG_API_DEF int
   lyplg_type_sort_int(const struct ly_ctx *UNUSED(ctx), const struct lyd_value *val1, const struct lyd_value *val2)
   {
       switch (val1->realtype->basetype) {
       case LY_TYPE_INT8:
           if (val1->int8 < val2->int8) {            // this the difference.
               return -1;
           } else if (val1->int8 > val2->int8) {        // this the difference.
               return 1;
           } else {
               return 0;
           }
           break;
   ....
   
6. michalvasko commented on Jan 26, 2026

   

   michalvasko

   on Jan 26, 2026

   Member

   More actions

   I found that the behavior of the lyplg_type_sort_enum interface is inconsistent with the behavior of other sort functions.

   So that may be the issue, was fixed in version 4.0.8.