Repository navigation
Conversation
|
Thanks for working on this. From the description, the "After a screenshot" setting sounds like it would cover what's asked in #1860. To be clear, I haven't reviewed the code itself. Quick question: does the "show overlay" option show a small corner preview like the one after recordings, which opens the editor when clicked? That's the behaviour I'm hoping for. Is anything blocking this from leaving draft? If you'd like a hand, I'm happy to help with testing on macOS or with any remaining work. |
|
Thanks so much for this contribution, @ryanr14! Cap's desktop app has now fully moved from Tauri to our new native GPUI app ( |
Summary
Save screenshots tosettings for Desktop, chosen folder, or app library only. Desktop is the default, and choosing a folder can open the folder picker immediately.After a screenshotfocused on follow-up actions: ask every time, open editor, show overlay, copy image, copy file path, copy Markdown image, reveal in Finder, upload link, or do nothing.original.pngas the fallback. Editor, upload, and image clipboard actions still use the internal screenshot source.save/saveToFolderaction handling for existing stores and deeplinks, and normalize old settings into the new save-destination model.Validation
cargo fmt --allcargo test -p cap-desktop screenshot_post_capture::tests --libcargo test -p cap-desktop general_settings::tests --libcargo test -p cap-desktop deeplink_actions::tests --libpnpm --dir apps/desktop exec vitest run src/utils/general-settings.test.tspnpm exec biome check apps/desktop/src/utils/tauri.ts "apps/desktop/src/routes/(window-chrome)/settings/general.tsx" apps/desktop/src/utils/general-settings.ts apps/desktop/src/utils/general-settings.test.tspnpm --dir apps/desktop exec tsc -p tsconfig.json --noEmitcargo check -p cap-desktop --libNote: local Rust commands require the ignored
apps/desktop/src-tauri/binaries/cap-cli-aarch64-apple-darwinsidecar to satisfy Tauri resource validation; I restored it from the already-built release binary for test runs and removed it afterward.