Repository navigation
fix(desktop-gpui): keep off-frame screenshot annotations in exports - #2742
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you drag an annotation past the edge of a screenshot, export grows the image to fit it, but the annotation itself got cut off at the old frame edge, so you'd get blank padding where your arrow or label should be. the code drew annotations onto the frame sized canvas before expanding it, which copied the old app's clipping on purpose during the port.
since this is the app that ships now, it draws the annotations after expanding, shifted along with the screenshot, so save, copy and share all keep them. blur masks still sample the original frame. the test checks every edge, 2x scaling and transparent backgrounds.


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues remain.Summary
Exports now draw annotations after expanding the canvas, keeping content beyond the screenshot edges.
The earlier outline-clipping finding is addressed by the current bounds calculation and regression tests. No new actionable issues were found. Tests were inspected, not run.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): include stroke extent..." · Reviewed by Greptile