Skip to content

fix(desktop-gpui): keep off-frame screenshot annotations in exports - #2742

Open
yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/screenshot-offframe-annotations
Open

yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/screenshot-offframe-annotations

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

if you drag an annotation past the edge of a screenshot, export grows the image to fit it, but the annotation itself got cut off at the old frame edge, so you'd get blank padding where your arrow or label should be. the code drew annotations onto the frame sized canvas before expanding it, which copied the old app's clipping on purpose during the port.

since this is the app that ships now, it draws the annotations after expanding, shifted along with the screenshot, so save, copy and share all keep them. blur masks still sample the original frame. the test checks every edge, 2x scaling and transparent backgrounds.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no blocking issues remain.

Summary

Exports now draw annotations after expanding the canvas, keeping content beyond the screenshot edges.

  • Screenshot exports keep annotations visible beyond the frame.

The earlier outline-clipping finding is addressed by the current bounds calculation and regression tests. No new actionable issues were found. Tests were inspected, not run.

Reviews (2) · Last reviewed commit: "fix(desktop-gpui): include stroke extent..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

Comment thread apps/desktop-gpui/src/screenshot_export.rs
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant