Skip to content

fix(desktop-gpui): align upload chunks for Google Drive - #2743

Open
yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/drive-upload-chunk-alignment
Open

yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/drive-upload-chunk-alignment

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

google drive resumable uploads need every chunk except the last to be a multiple of 256 KiB. the chunk size was just the file size over 100, clamped to 5 to 15 MiB, so most exports got odd sizes, a 601 MiB export used 6,301,941 byte chunks, and drive rejects those. retrying the same chunk can't help.

now the size gets rounded down to 256 KiB inside the same bounds. sizing is shared, so drive urls that come back without provider info are covered too, and s3 parts just get slightly rounder sizes. the drive loopback test now goes through the real sizing instead of a fixed 1000 bytes.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Rounds upload chunks down to multiples of 256 KiB so Google Drive accepts intermediate chunks.

  • Multipart uploads send aligned full chunks to Google Drive.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): align upload chunks f..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant