Repository navigation
fix(desktop-gpui): align upload chunks for Google Drive - #2743
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google drive resumable uploads need every chunk except the last to be a multiple of 256 KiB. the chunk size was just the file size over 100, clamped to 5 to 15 MiB, so most exports got odd sizes, a 601 MiB export used 6,301,941 byte chunks, and drive rejects those. retrying the same chunk can't help.
now the size gets rounded down to 256 KiB inside the same bounds. sizing is shared, so drive urls that come back without provider info are covered too, and s3 parts just get slightly rounder sizes. the drive loopback test now goes through the real sizing instead of a fixed 1000 bytes.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Rounds upload chunks down to multiples of 256 KiB so Google Drive accepts intermediate chunks.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): align upload chunks f..." · Reviewed by Greptile