Repository navigation
fix(rendering): lay out the camera from the current frame's size - #2748
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the camera bubble, split layout and camera only scenes were all laid out from the camera size stored for the whole recording, which comes from the first clip. the frame actually uploaded is the current clip's though, so when a later clip's camera had a different resolution or aspect, it showed up stretched or cropped wrong.
now the layout uses the current camera frame's own size and only falls back to the stored size when there's no frame yet, same as the screen side does. the new test renders 72 size and layout combinations pixel exact, and the camera export and playback oracles pass.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Camera layouts now use the current decoded frame’s dimensions, with the stored dimensions as a fallback when no frame is available.
Reviews (1) · Last reviewed commit: "fix(rendering): use current camera dimen..." · Reviewed by Greptile