Skip to content

fix(rendering): lay out the camera from the current frame's size - #2748

Open
yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/camera-current-dimensions
Open

yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/camera-current-dimensions

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

the camera bubble, split layout and camera only scenes were all laid out from the camera size stored for the whole recording, which comes from the first clip. the frame actually uploaded is the current clip's though, so when a later clip's camera had a different resolution or aspect, it showed up stretched or cropped wrong.

now the layout uses the current camera frame's own size and only falls back to the stored size when there's no frame yet, same as the screen side does. the new test renders 72 size and layout combinations pixel exact, and the camera export and playback oracles pass.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Camera layouts now use the current decoded frame’s dimensions, with the stored dimensions as a fallback when no frame is available.

  • Camera layouts follow the current clip's frame size.

Reviews (1) · Last reviewed commit: "fix(rendering): use current camera dimen..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant