Repository navigation
fix(editor): show the final frame when seeking to the timeline end - #2750
Merged
richiemcilroy merged 3 commits intoOct 21, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jumping the playhead to the very end of the timeline left whatever frame was on screen before, because the end time is exclusive in the timeline mapping, so the preview renderer found no segment for it and skipped rendering.
now preview requests get clamped to the last real output frame using the current project snapshot, so seeking to the end shows the final frame. the mapping rules themselves don't change. the new seek test covers the end after the timeline shrinks, fractional and sub frame durations and an exact cut boundary, and the playback and seek oracles pass.
The PR appears safe to merge; both previously reported issues are addressed.Summary
The preview clamps end seeks to the last output frame using the current project settings.
Reviews (2) · Last reviewed commit: "fix(editor): pick the last preview frame..." · Reviewed by Greptile