Repository navigation
Conversation
omar-cos
requested changes
Oct 20, 2026
|
|
||
| readonly isInputValid = computed(() => this.userInput() === this.selectedScientist); | ||
| readonly hasMultipleResources = computed(() => (this.resources()?.length ?? 0) > 1); | ||
| readonly showList = computed(() => !this.dialogData.singleMessageKey || this.hasMultipleResources()); |
Contributor
There was a problem hiding this comment.
I believe project deletion should show the short confirmation message when there are no sub-components, same as component deletion does. right now it looks like it always shows the list and warning instead, even when the list would be empty. Can you verify/confirm if this is handled correctly?
Collaborator
Author
There was a problem hiding this comment.
I didn’t change any of the deletion logic. It works the same way as before. I just consolidated everything into one shared flow. If we need to change the behavior, we should discuss it with Product first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes