✨ Current Line Highlight #34

Activity

1. austincondiff

   added

   enhancementNew feature or requestNew feature or request

   on Mar 23, 2022
2. austincondiff

   changed the title [-][FEAT] - Current Line Highlight[/-] [+]✨ Current Line Highlight[/+] on Mar 31, 2022
3. stale

   added

   wontfixThis will not be worked onThis will not be worked on

   on May 30, 2022
4. CodeEditApp

   deleted a comment from stale on Jun 1, 2022
5. stale

   removed

   wontfixThis will not be worked onThis will not be worked on

   on Jun 1, 2022
6. austincondiff

   transferred this issue fromCodeEditApp/CodeEditon Jun 24, 2022
7. austincondiff

   added this to CodeEdit Projecton Sep 28, 2022
8. austincondiff

   moved this to Todo in CodeEdit Projecton Sep 28, 2022
9. NakaokaRei commented on Oct 3, 2022

   

   NakaokaRei

   on Oct 3, 2022

   More actions

   @austincondiff
   I want to work on this issue!
   Can you please assign it to me?
10. austincondiff commented on Oct 3, 2022

    

    austincondiff

    on Oct 3, 2022

    Last edited by austincondiff

    CollaboratorAuthor

    More actions

    Sure thing! One thing to note, the top line is highlighted in this screenshot, so it is working however there are two things that need to happen here.

    1. The highlight needs to extend into the gutter. And the separator needs to be removed.
    2. The line number needs to be more prominent (and other line numbers less prominent).

    

    We are trying to make it look like this (code folding will come later)...

    

    One thing to consider is it might have something to do with STTextView so you may need to submit a PR over there as well.

    To get rid of the separator, we need to do the following in STTextViewController.swift...

    - rulerView.separatorColor = theme.invisibles
    + rulerView.drawSeparator = false
11. austincondiff

    assigned

    NakaokaRei

    on Oct 3, 2022
12. austincondiff

    added

    hacktoberfest

    on Oct 3, 2022
13. austincondiff

    moved this from Todo to In Progress in CodeEdit Projecton Oct 3, 2022
14. NakaokaRei commented on Oct 4, 2022

    

    NakaokaRei

    on Oct 4, 2022

    More actions

    @austincondiff
    Thank you for the advice!
    I will investigate and report back if I have to change STTextView 🙇

    👍React with 👍1Reacted by Austin Condiff
15. NakaokaRei commented on Oct 4, 2022

    

    NakaokaRei

    on Oct 4, 2022

    More actions

    @austincondiff
    As far as you can tell, as you are talking about, it doesn't look like I can tackle this issue without changing STTextView.
    This is difficult for me and I have no prospects for development, so I will remove the assign for now.
    Sorry 🙇

    I think this CodeEdit is a great project and I'll comment as soon as I find an issue I can do myself!
16. NakaokaRei

    removed their assignment

    on Oct 4, 2022
17. austincondiff

    moved this from In Progress to Todo in CodeEdit Projecton Oct 12, 2022
18. austincondiff

    removed

    hacktoberfest

    on Nov 4, 2022
19. Eliulm commented on Jan 3, 2023

    

    Eliulm

    on Jan 3, 2023

    Contributor

    More actions

    I am currently finalizing my pull request for the STTextView repository. With that, we can add line highlighting, just like in Xcode.

    🚀React with 🚀2Reacted by Austin Condiff and Lukas Pistrol
20. austincondiff commented on Jan 25, 2023

    

    austincondiff

    on Jan 25, 2023

    CollaboratorAuthor

    More actions

    Closing this as the line highlight has been implemented.
21. austincondiff

    closed this as completedon Jan 25, 2023
22. github-project-automation

    moved this from Todo to Done in CodeEdit Projecton Jan 25, 2023