Skip to content

Research removing /people from site #55

Open

Description

@machow

From discussion with leadership (e.g. @mariekers , Kat, and Julia), it sounds like people are on board with removing /people.

  • What are the steps needed?
  • Are there surprising issues that arise (e.g. can people still edit their profiles? create projects?)

Activity

  1. tblacknc commented on Feb 2, 2022

    @tblacknc
    Contributor

    This looks easily done by putting a redirect in the people.php file:

    <?php
    
    Site::redirectPermanent("/", $_GET);
    

    And removing the 2 links in the header.

    Editing your profile is in the /profile directory and creating/editing projects in the /projects directory and are verified not to be effected.

  2. tblacknc commented on Feb 3, 2022

    @tblacknc
    Contributor

    Did this in 2 PRs, I am sure there is a way to do it in 1 but it wasn't jumping out at me:

    Removal of link:
    http://pr-57.codeforphilly.sandbox.k8s.phl.io/

    redirect:
    http://pr-58.codeforphilly.sandbox.k8s.phl.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions