Repository navigation
Conversation
The OTLP trace writers dropped the Metadata baggage map, which carries the propagation tags (_dd.p.dm, _dd.p.ksr, _dd.p.tid...) and baggage items injected as tags. Write it like the Datadog mappers do, with propagation tags on the local root span only, so the sampling decision maker reaches the Agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Exports the span propagation tags (
_dd.p.dm,_dd.p.ksr,_dd.p.tid, ...) and baggage-as-tags items as string attributes in OTLP trace export (protobuf and JSON), mirroring the Datadog mappers:OtlpTraceProto/OtlpTraceJsonMetaWriters now writeMetadata.getBaggage(), which was computed but never serialized. Span tags win on a key clash, so OTLP attribute keys stay unique.ROOT_PROPAGATION_TAGS), likeTraceMapperV0_4/V0_5; child spans don't carry_dd.p.*(no per-span_dd.p.tid).Motivation
With
DD_TRACE_OTEL_EXPORTER=otlp, remote and adaptive sampling rules are applied (priority,_dd.rule_psrare exported), but the sampling decision maker_dd.p.dmnever was. The Agent then falls back to a default decision maker, so the backend doesn't count the traffic as rule/adaptive-sampled and adaptive sampling can't converge for the service.This complements DataDog/datadog-agent#58471, which preserves
_dd.p.dmfrom OTLP span attributes (ort.dmfrom a tracestatedd=member). The .NET equivalent is DataDog/dd-trace-dotnet#9498.Additional Notes
_dd.p.dm:-4; with this change the root span is expected to carry the rule's decision maker (-11remote user rule /-12remote adaptive rule), which the Agent keeps with [trace-agent] Preserve tracer sampling decision maker in OTLP receiver datadog-agent#58471. The end-to-end run with this exact build is still to do.propagationTagsAreWrittenOnTheLocalRootSpanOnlyinOtlpTraceProtoTestandOtlpTraceJsonCollectorTest(fail before, pass after).:dd-trace-core:spotlessCheckcouldn't run locally because the Eclipse p2 site used by the Groovy formatter was down; changed files were checked with google-java-format 1.36.1.dd=tracestate member, so the OTLPtrace_statedoesn't carryt.dm._dd.p.*, while the Datadog mappers put them on the first span of each chunk.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A
🤖 Generated with Claude Code