Repository navigation
Fix connection queries and persistence without repainting - #42
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On an unpainted WinForms canvas,
ConnectOptionsucceeds and data transfers, butGetConnectionInfo()is empty andGetCanvasData()loses the connections because both read the drawing cache. InputGetConnectedOption()also compares against the output endpoint, so it returns no upstream peers in both implementations. Related: #21 and #33.Change
Read WinForms connection information from the actual option graph and use that snapshot for saving; correct the input-to-output lookup in both implementations. Skip the supported
STNodeOption.Emptyoutput spacer during path traversal (otherwise connecting a node containing a spacer throws).Validation
On Windows, both commands pass:
dotnet run --project tests/Connections/Connections.csproj -f net48dotnet run --project tests/Connections/Connections.csproj -f net8.0-windowsThe regression creates tiny nodes, transfers data, queries both endpoints, saves/loads before painting, and checks multiple peers/disconnection and a spacer. No plugins or external graph files are needed.
Native WPF net8 builds; the existing net10 target separately fails with CS0012 for System.Private.Windows.GdiPlus (also reproduced on unchanged main). No interactive UI acceptance or full demo suite is claimed.