Repository navigation
Preserve node option locks and saved locked connections - #43
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WinForms saves
LockOptionfrom_LockLocation. Saving/loading a node with different option/location locks changes its behavior. After correcting that field alone, restoring an existing edge between option-locked nodes is rejected by the normal edit-lock check. Related: #28.Change
Serialize the independent option-lock flag. While restoring each saved edge, temporarily lift the two edit locks and restore them in
finally; normal interactive connection checks are unchanged. Update the matching CN/EN tutorial source snippets.Validation
dotnet run --project tests/Locks/Locks.csprojpasses on Windows/.NET Framework 4.8. It checks all four option/location-lock combinations, positions, and existing connections after a real canvas save/load. It paints offscreen before saving to isolate this repair from the separate drawing-cache persistence issue. The one-field-only repair failed the connection assertion.No interactive UI or full demo acceptance is claimed.