Repository navigation
Fix double and boolean array property roundtrips - #44
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A node with a supported
[STNodeProperty] double[]orbool[]property saves successfully but cannot load its own canvas: the existing matching parsers are guarded by repeatedinttype checks, so they are unreachable and loading throwsInvalidCastException.Change
Use the matching double/bool element-type checks in both the WinForms and native WPF property descriptors. No format, fallback, or API change.
Validation
On Windows, both executable regressions pass through actual
GetCanvasData()/LoadCanvas()calls, checking every element of nonempty double and boolean arrays:dotnet run --project tests/Arrays/Arrays.csproj -f net48dotnet run --project tests/Arrays/Arrays.csproj -f net8.0-windowsThe same double-array invocation failed on the base with
InvalidCastException. Native WPF net8 builds; unchanged main's net10 target separately fails with CS0012 for System.Private.Windows.GdiPlus. No interactive property-editor/full demo acceptance is claimed.