Repository navigation
Correct the README executable-node filter and connection comments - #45
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's start example currently skips every
BaseNode, including all input/output nodes. For a graph containing the example's executable node types, both required lists stay empty and execution always throws. Invert the filter so it skips unrelated nodes instead.Also correct the reversed single/multi-connection comments:
bSingle=trueis single,falseis multi.Validation: traced the example against its declared hierarchy and ran an isolated .NET Framework 4.8 fixture with synthetic input/output/other executable nodes and an unrelated node. It starts other -> output -> input with the corrected filter. No file-writing example or user graph was executed. Documentation-only change.