This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Repository navigation
Issue-5: Add support for SSL - #27
Merged
Merged
Conversation
mbtamuli
reviewed
Jan 25, 2018
| -v /etc/nginx/certs:/etc/nginx/certs \ | ||
| -v /etc/nginx/conf.d:/etc/nginx/conf.d \ | ||
| -v /var/run/docker.sock:/tmp/docker.sock:ro \ | ||
| --network $SITE_NAME \ |
Contributor
There was a problem hiding this comment.
How do you propose this method will work when a second site is created?
mbtamuli
suggested changes
Jan 29, 2018
| runNginxProxyAndLetsEncrypt | ||
| docker network create $SITE_NAME | ||
| docker network connect $SITE_NAME nginx-proxy | ||
| docker network connect $SITE_NAME letsencrypt |
Contributor
There was a problem hiding this comment.
@vishaldodiya You will also have to disconnect letsencrypt container while deleting site.
mbtamuli
suggested changes
Jan 29, 2018
| restart: always | ||
| environment: | ||
| - VIRTUAL_HOST | ||
| - LETSENCRYPT_HOST=${VIRTUAL_HOST} |
Contributor
There was a problem hiding this comment.
LETSENCRYPT_HOST will be required for mail service also.
mbtamuli
approved these changes
Jan 29, 2018
Contributor
|
@vishaldodiya Please add docs for this too. #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.