Skip to content

[Help wanted][Enhancement] Refactor condition matchers #12

Open
Open
[Help wanted][Enhancement] Refactor condition matchers#12
Labels
good first issueGood for newcomers

Description

@hezean
hezean
opened on Jul 11, 2022

server-sdk-java/src/main/java/com/featureprobe/sdk/server/model/Condition.java

Lines 25 to 33 in 8c71ba4

private static final Map<PredicateType, StringMatcher> stringMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, SegmentMatcher> segmentMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, DatetimeMatcher> datetimeMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, NumberMatcher> numberMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, SemverMatcher> semverMatchers = new EnumMap<>(PredicateType.class);

using map for predicate matching isn't a good practice, consider using strategy pattern or so.

Activity

  1. hezean
    changed the title [-][Help wanted] refactor: condition matchers[/-] [+][Help wanted][Enhancement] Refactor condition matchers[/+] on Sep 24, 2022
  2. FengShang
    added
    good first issueGood for newcomers
    on Nov 21, 2022
  3. FengShang
    added this to Product Backlogon Nov 21, 2022
  4. FengShang
    moved this to 🆕 New in Product Backlogon Nov 21, 2022
  5. FengShang
    moved this from 🆕 New to 📋 Backlog in Product Backlogon Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomers

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions