Repository navigation
fix(asset): update BatchGetAssetsHistory sample and IT fixture - #10357
Merged
XrossFox merged 2 commits intoOct 21, 2026
Merged
Conversation
- Set ContentType.RESOURCE in BatchGetAssetsHistoryExample - Create and clean up a temporary GCS bucket in QuickStartIT for testBatchGetAssetsHistory
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates BatchGetAssetsHistoryExample.java to use ContentType.RESOURCE instead of ContentType.CONTENT_TYPE_UNSPECIFIED. It also refactors QuickStartIT.java to use a dynamically created and deleted temporary bucket for the BatchGetAssetsHistory test. Feedback was provided on QuickStartIT.java to remove a redundant !got.isEmpty() check, as the output stream will always contain at least a newline character, making the conditional check unnecessary.
amcolin
approved these changes
Oct 21, 2026
amcolin
left a comment
Contributor
There was a problem hiding this comment.
Great fix!
Since we're making these changes, here are two small things we can clean up/remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/575851644
Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions