Repository navigation
Fix profiling CI action failing - #2734
Merged
Merged
Conversation
TrueDoctor
approved these changes
Jun 18, 2025
TrueDoctor
enabled auto-merge (squash)
June 18, 2025 13:14
Keavon
pushed a commit
that referenced
this pull request
Jun 20, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Profiling Changes is expected to fail since the profiling ci uses the master branch to compare to, with the code error this PR corrects.
Investigation
Performance tests on master are broken, seems that the profile CI isn't clean and when failing, does not prevent auto-merge.
compile, breaking the profile cicargo shear#2723 fails the profile step, gets auto-merged anyway