Repository navigation
Fix wire type matching to only allow conversions the compiler actually makes - #4688
Merged
Merged
Conversation
Member
|
I deliberatly choose not to implement this in my pr because dealing with rank promotions is very ugly, I will need time to review this in detail since it touches the compiler and type resolution so you may not merge this on your own |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keavon
force-pushed
the
input-adapter-conversion-table
branch
from
October 13, 2026 23:22
d091b36 to
46b6616
Compare
Member
|
I don't think I'll be able to impartialy judge the code quality at the moment or have time to work on improvements. So if you need merge this to reach some goal, you can do that without risking me holding this against you |
Keavon
force-pushed
the
input-adapter-conversion-table
branch
from
October 21, 2026 04:53
46b6616 to
832f5aa
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4670. When you hover a node with a wire, it reveals hidden inputs based on a type check that didn't match what the compiler does, so it got things wrong in both directions:
One example of something this fixes from #4670 is the case of dragging a Vector wire over a Fill or Stroke node which should expand the node to show the Paint parameter. It should work equally for both, as they're both valid. But as of #4670, it only the Fill node works and the Stroke node doesn't expand to offer it, which this followup PR fixes. It also fixes a number of misleading and broken type details across the tooltips, such as the Path node's primary input showing the entire set of all inputs accepted by the Monitor node (essentially all wire types, which the tooltip can't hope to fit on screen).