Repository navigation
Conversation
The byte figure already shown per row is hard to judge against the size of the game, so add the percentage of the original folder size it represents. The column is derived from DisplayedSavings rather than DetailSavings: a compressed game with a pending Steam update shows an estimate in the list but an actual figure in the details pane, and the two adjacent cells in a row must agree with each other. The header needs 102px at the 14px font the Fluent button style applies, so the column is fixed rather than star-sized; star sizing squeezed it to 89px and clipped the trailing "%". The Savings column's minimum rises from 60 to 88 for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a SAVINGS % column to the Steam library list: the savings already shown next to it, as a percentage of the game's original uncompressed size.
This is the formula from #98, where you noted percentages are more intuitive to most people than a ratio.

Why a new
DisplayedSavingsPercentageinstead of the existingSavingsPercentageSteamDetailedResultalready hasSavingsPercentage, but it derives fromDetailSavingswhile the row's SAVINGS cell showsDisplayedSavings. The two diverge for a compressed game with a pending Steam update - the row shows the wiki estimate, the details pane shows the measured figure. ReusingSavingsPercentagewould put a percentage in the row that does not describe the number immediately to its left. The details pane keeps usingSavingsPercentage, which is correct there since it displaysDetailSavings.Column sizing
The header button needs 102px: the Fluent
Buttonstyle raisesFontSizeto 14, and the sort icon plus its margins add 19px. Star sizing only gave the column 89px at a 1104px-wide window and clipped the trailing%, so the column is fixed at 104px. The SAVINGS column'sMinWidthgoes 60 -> 88 so that taking 104px out of the pool does not clip its 85.4px header in turn.Tradeoff, worth your judgement before merging: this page has no responsive handling - the header grid and the row template grid are hand-duplicated with identical column definitions - so the 104px comes out of the one flexible column, GAME. At a 1104px window GAME drops to its 135px floor and long names ellipsize, where the 6-column layout gave it roughly 198px.
Localisation
Only
en-AU(source) andzh-CNgot entries. The other catalogues will pick up# LOC:TODOstubs from the next Debug build'sLocalisationCatalogueBuilderrun, which is the route your translators already use - and it keeps this out of the way of #686 and #678, which rewriteit-IT.tomlandtr-TR.tomlwholesale.@versionandmanifest.tomlare bumped for both files. Without that,SynchroniseEmbeddedLanguagesAsyncwill not overwrite an existing user's local copy (it compares versions), so upgraders would never see the new string even once it exists in the repo.Verification
Recently Updatedstate. That is the only case whereDisplayedSavingsandDetailSavingsdiverge, and I had no sample to test against.