Skip to content

Using own Feature - constant for "delete with returning" #1597

Closed

Description

@gitmotte

#1527 introduced DELETE with RETURNING and used Feature.insertReturningExpressionList
within the validation net.sf.jsqlparser.util.validation.validator.DeleteValidator - the Feature.insertReturningExpressionList is part of the validation group FeaturesAllowed.INSERT and therefore only allowed for INSERT statements.

The bugfix fixes the problem with a new feature constant Feature.deleteReturningExpressionList which is part of the validation group FeaturesAllowed.DELETE.

Activity

  1. manticore-projects commented on Jul 23, 2022

    @manticore-projects
    Contributor

    Thank you for helping me out! I honestly have no idea how this validation framework works and tried brute force.

  2. gitmotte commented on Jul 23, 2022

    @gitmotte
    ContributorAuthor

    Are the correlations clearer for you now, when you look at the changes?

  3. gitmotte commented on Jul 23, 2022

    @gitmotte
    ContributorAuthor

    I've added a "Further development" section to the wiki of my fork - could you please merge it to the original wiki of JSQLParser @wumpz ?

    https://github.com/gitmotte/JSqlParser/wiki/Examples-of-SQL-Validation#further-development

    (don't know how to add merge requests for wiki-pages)

  4. wumpz commented on Jul 26, 2022

    @wumpz
    Member

    merged it :) manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions