Repository navigation
feat: allow GROUP BY ALL and DISTINCT for PostgreSQL - #2842
Merged
manticore-projects merged 2 commits intoOct 22, 2026
Merged
Conversation
princejain756
force-pushed
the
pg-groupby-modifier
branch
from
October 21, 2026 21:24
7833504 to
d65d97c
Compare
Contributor
|
Am I right to assume that this overlaps with #2830 but is broader? |
princejain756
force-pushed
the
pg-groupby-modifier
branch
from
October 22, 2026 11:08
d65d97c to
7152c16
Compare
Contributor
Author
|
Correct - #2830 handles GROUPING SETS under GROUP BY DISTINCT, while this adds ALL and DISTINCT before any grouping element, so it covers that case plus plain columns and rollups. Conflicts resolved, rebased on master. |
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2785.
PostgreSQL accepts an optional ALL or DISTINCT modifier directly after GROUP BY:
The DISTINCT form removes duplicate grouping sets before processing (PostgreSQL docs). JSQLParser rejected it at the DISTINCT token.
This adds a semantic-lookahead-gated ALL|DISTINCT slot in GroupByColumnReferences, active only under the POSTGRESQL dialect, plus all/distinct flags on GroupByElement so both toString and the deparser round-trip the modifier. Other dialects and existing GROUP BY forms are unchanged.
10,735 tests, 0 failures, 25 skipped.