Repository navigation
🧹 Sentinel: Remove unused persist_floating_keyboard - #719
LeanBitLab wants to merge 1 commit into
Conversation
…d`. Here is a summary of the changes: 💡 **What:** I removed the `PREF_PERSIST_FLOATING_KEYBOARD` preference, the `mPersistFloatingKeyboard` property, and the `persist_floating_keyboard` strings across all locale values. The feature was deprecated, and the related property was hardcoded to false and being cleaned up in SettingsValues.kt. 🔍 **Verification:** I searched the repository to verify there are zero remaining references to the `persist_floating_keyboard` strings and properties. I also ran `./gradlew :app:assembleStandardDebug` and `./gradlew :app:testStandardDebugUnitTest`, and both completed with no errors. 📦 **Impact:** This reduces technical debt, cleans up obsolete strings to save space, and removes dead SharedPreferences cleanup logic from the Settings flow.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Removed the
PREF_PERSIST_FLOATING_KEYBOARDpreference, propertymPersistFloatingKeyboard, and thepersist_floating_keyboardstrings across all locale values. The feature was deprecated and the related property was hardcoded to false and being cleaned up in SettingsValues.kt.🔍 Verification:
Searched the repository via
grepto verify zero remaining references topersist_floating_keyboardstrings and properties. Ran./gradlew :app:assembleStandardDebugand./gradlew :app:testStandardDebugUnitTestwith no errors.📦 Impact:
Reduces technical debt, cleans up obsolete strings saving space, and removes dead SharedPreferences cleanup logic from the Settings flow.
PR created automatically by Jules for task 10788860027012443306 started by @LeanBitLab