Skip to content

PyTorch-Tutorial/tutorial-contents/403_RNN_regressor.py contains a weird line of code #49

Open

Description

@BlackTentacle

I tried some RNN regression learning based on the code in the "PyTorch-Tutorial/tutorial-contents/403_RNN_regressor.py" file, which did not work for me at all.

According to an accepted answer on stack-overflow (https://stackoverflow.com/questions/52857213/recurrent-network-rnn-wont-learn-a-very-simple-function-plots-shown-in-the-q?noredirect=1#comment92916825_52857213), it turns out that the line

h_state = h_state.data

of the tutorial file does not do what it is supposed to be doing. It does not actually break the connection to the previous iteration as specified in the commment. Rather the line

h_state = None

should do the trick (according to the accepted answer).

Activity

  1. simon19891101 commented on Oct 27, 2018

    @simon19891101

    Indeed, I guess the comment is for the case whereby elements in batches are unrelated, like the MNIST example, however the code is correct here for continuous data.

  2. MorvanZhou commented on Oct 29, 2018

    @MorvanZhou
    Owner

    Is the bug related to pytorch's version? The pytorch '0.4.1' runs fine.

  3. SkatingLiu commented on Mar 8, 2019

    @SkatingLiu

    when I use torchvision.datasets.MNIST, why occurs TypeError: init() missing 1 required positional argument: 'total'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions