Skip to content

fix: ensure error summary sheet populates entities in deterministic way #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenhsd wants to merge 1 commit into
base: release_v010
Choose a base branch
from
Open

fix: ensure error summary sheet populates entities in deterministic way #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/dve/pipeline/foundry_ddb_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
duckdb_get_entity_count,
duckdb_write_parquet,
)
from dve.core_engine.configuration.v1 import V1ErrorReportConfig
from dve.core_engine.exceptions import CriticalProcessingError
from dve.core_engine.models import SubmissionInfo
from dve.core_engine.type_hints import URI
Expand Down Expand Up @@ -102,12 +101,10 @@ def apply_business_rules(
return submission_info, SubmissionStatus(processing_failed=True)

def error_report(
self, submission_info: SubmissionInfo,
submission_status: Optional[SubmissionStatus] = None ,
error_report_config: Optional[V1ErrorReportConfig] = None,
self, submission_info: SubmissionInfo, submission_status: Optional[SubmissionStatus] = None
):
try:
return super().error_report(submission_info, submission_status,error_report_config)
return super().error_report(submission_info, submission_status)
except Exception as exc: # pylint: disable=W0718
self._logger.exception("Error reports raised exception:")
sub_stats = None
Expand Down
11 changes: 5 additions & 6 deletions src/dve/pipeline/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,6 @@ def error_report(
self,
submission_info: SubmissionInfo,
submission_status: Optional[SubmissionStatus] = None,
error_report_config: Optional[V1ErrorReportConfig] = None,
) -> tuple[
SubmissionInfo, SubmissionStatus, Optional[SubmissionStatisticsRecord], Optional[URI]
]:
Expand All @@ -968,11 +967,10 @@ def error_report(
raise AttributeError("processed files path not provided")

self._logger.info("Reading error dataframes")
if error_report_config is None:
if not self.rules_path:
raise AttributeError("rules path not provided")
_, config, _ = load_config(submission_info.dataset_id, self.rules_path)
error_report_config = config.error_report
if not self.rules_path:
raise AttributeError("rules path not provided")
_, config, _ = load_config(submission_info.dataset_id, self.rules_path)
error_report_config: V1ErrorReportConfig = config.error_report
errors_df, aggregates = self._get_error_dataframes(
submission_info.submission_id,
error_report_config.record_rejection_reporting,
Expand Down Expand Up @@ -1007,6 +1005,7 @@ def error_report(
summary_items = er.SummaryItems(
submission_status=submission_status,
summary_dict=summary_dict,
table_columns=[entity.upper() for entity in config.contract.datasets],
row_headings=[
e.reporting_name
for e in ErrorReportCategories
Expand Down
Loading