Skip to content

Testing page refresh - #216

Merged
andyblundell merged 3 commits into
masterfrom
testing_page_sectioning
Nov 4, 2021
Merged

andyblundell merged 3 commits into
masterfrom
testing_page_sectioning

Conversation

@lila1-work

Copy link
Copy Markdown
Contributor

Page restructured to make it easier to read and find information. Further work to do to split it up but please merge this so it's easier for other people to help work on this too.

@lila1-work
lila1-work requested a review from dlavender4 November 4, 2021 20:11
@lila1-work
lila1-work requested a review from a team November 4, 2021 20:11
Comment thread practices/testing.md
### Unit Testing Guidence
* Tests act as documentation of the system's behaviour and should be clear enough to do this effectively.
* Tests are written alongside or before whatever they are testing.
* Tests are code (see [everything as code](../patterns/everything-as-code.md)).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find the place where this sentence has been moved? I take it has been blended into the context of the other points i.e. "testing is assisted by automation"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefaniuk I think it's fine for this line to be dropped, since the restructure of the page moves this into a section specifically about unit testing.

It might be worth repeating the test-code-must-be-treated-as-kindly-as-any-other-type-of-code message in here somewhere (which is the message really, rather than just that automated tests are code!), but obviously that's not just relevant to unit tests, so it probably wouldn't be appear here in the file.

I'll go ahead and merge but let's convert your comment to an issue so we don't forget about it.

Thanks @stefaniuk and @lila1-work

@andyblundell
andyblundell merged commit 2acab8b into master Nov 4, 2021
@andyblundell
andyblundell deleted the testing_page_sectioning branch November 4, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants