Plugins don't get all the needed information...

When using the hook; plugins don't know if the hook is being targeted at ios or android. I'm having to parse the command line myself to pull this info out even though the nativescript command should have that information.

In addition the platform folder imho should be pointing to the actual platform that is being targetted; not the ./platforms folder, as I then have to create the entire path to where the ios or android build data resides.

@Fatme

@Fatme any news on this?
Facing this issue too

@farfromrefug

@farfromrefug,

The first option is to use $options.argv._. It will return the full command line as array. After that you can search for ios or android item.

module.exports = function ($options) {
    const commandLine = $options.argv._;
    const isiOSPlatform = commandLine.find(item => item.toLowerCase() === "ios");
}

The second option is to use $devicesService.platform but it will NOT work for all the commands and all the hooks.
It will work only for device related commands (where device discovery is started) like tns run android, tns run ios, tns debug ios, tns debug anroid.
It will not work for device related commands when the platform is not provided - for example tns run.
It will not work for commands like tns preapre ios where device discovery is not started.

module.exports = function ($devicesService) {
    const platform = $devicesService.platform;
}

@Fatme

@Fatme @NathanaelA thanks for the explanations! I think I ll use the command line args.

@farfromrefug

@farfromrefug,

The drawback of this approach is that it will not work when {N} CLI is used as library.

@Fatme

@Fatme when is it used as a library? sidekick?

@farfromrefug

@farfromrefug
Yes, sidekick

Navigation Menu

Repository navigation

Plugins don't get all the needed information... #2

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Plugins don't get all the needed information... #2

Description

Activity

farfromrefug commented on Feb 2, 2019

NathanaelA commented on Feb 2, 2019

Fatme commented on Feb 2, 2019

farfromrefug commented on Feb 2, 2019

Fatme commented on Feb 3, 2019

farfromrefug commented on Feb 3, 2019

Fatme commented on Feb 3, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions