Skip to content

fix(plugins): a local file's card no longer says it was not scanned beside its scan - #528

Closed
nt-nerdtechnic wants to merge 1 commit into
mainfrom
fix/0228-local-card-scan-wording
Closed

nt-nerdtechnic wants to merge 1 commit into
mainfrom
fix/0228-local-card-scan-wording

Conversation

@nt-nerdtechnic

Copy link
Copy Markdown
Collaborator

Summary

0.2.27 checklist §10 (LOW, since ca47032): a plugin installed from a file now gets Navide's own static scan (W1, pluginIpc.ts localScan: 'ran'), but its disclosure card (install confirm dialog PluginTrustDialog, agent request card PluginAgentRequestDialog, developer panel) still said:

  • provenance: "…has no Navide Registry signature and was not scanned by Navide",
  • heading: "What the publish-time scan found",
  • coverage: "Scanned by the Navide Registry at publish (…)",
  • limits: "The scan was run by the Navide Registry." / "This version has no system scan…", no-scan: "This version was published before system scans…".

For localSource only, the card now reads:

  • provenance: "…has no Navide Registry signature and Navide has not reviewed it."
  • heading: "What Navide's scan of this file found"; coverage: "Scanned by Navide on this computer (…)"; limits: "The scan informs this card; it never decides the install."
  • without a scan: "Navide did not scan this file; below/the above is only this Navide plugin's own declaration."

zh-TW / ja-JP strings added alongside. Marketplace cards are unchanged: the existing PluginDisclosureCard.main-baseline.html file snapshot (verified card, listing card, no disclosure, with and without a marketplace source row) still matches byte for byte; the snapshot file is not touched.

Not changed, for coordination: PluginSourceBadge still says "Not scanned (only Navide plugins installed from the Navide Marketplace are scanned by Navide)" for local sources. That component is being changed by another pane (修-0228-DX三個高, A1 gaps), so it is left to them; it has the same contradiction when the local scan ran.

Test plan (red → green)

  • New PluginDisclosureCard local file scan wording tests (scanned / not scanned × wording, and no missing key in en-US, zh-TW, ja-JP).
  • Red (component and locales at origin/main): pnpm vitest run src/renderer/src/components/__tests__/PluginDisclosureCard.test.ts --maxWorkers=1 -t "local file scan wording" → 2 failed, 3 passed.
  • Green: pnpm vitest run PluginDisclosureCard, PluginTrustDialog*, PluginAgentRequestDialog*, MarketplacePane*, ExtensionsPane*, MarketplaceDeveloperPanel* tests + packages/plugin-ui/src/foundation/i18n/__tests__/{glossary,locales}.test.ts, --maxWorkers=2 → 8 files, 220 passed.
  • pnpm typecheck:web → exit 0.

Regression: existing plugins

  • Marketplace / Registry cards: main-baseline snapshot unchanged (2 tests). Trust dialog, agent request dialog, Marketplace and Extensions panes: all green above.
  • Wording only; no install, scan or consent logic changed.

Protection check

  • git diff origin/main..HEAD --stat -- 'backend/agent_team_backend/credential_*' 'backend/agent_team_backend/quota_*' 'backend/agent_team_backend/usage_*' → empty; no account-switch code touched.
  • No function deleted; scanKey keeps its signature (reads props.localSource). Locale key pluginDisclosure.provenance.local reworded; new keys scanHeadingLocal, scannedLocally, limitsWithoutScanLocal, scan.coverage.local, scan.noScanLocal.
  • No limit added or changed.

🤖 Generated with Claude Code

…eside its scan

Since 0.2.27 a plugin installed from a file gets Navide's own static scan,
but its disclosure card still read "was not scanned by Navide" above a
"What the publish-time scan found" section, a coverage line crediting the
Navide Registry at publish, and "The scan was run by the Navide Registry".
For local files only (localSource) the card now says Navide scanned the file
on this computer and that the scan never decides the install, or that Navide
did not scan it; the provenance line says Navide has not reviewed it.
Marketplace cards render exactly as on main (main-baseline snapshot).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@nt-nerdtechnic
nt-nerdtechnic marked this pull request as ready for review October 20, 2026 22:37
nt-nerdtechnic added a commit that referenced this pull request Oct 20, 2026
…eside its scan (#528)

Squash-merged from origin/pr-528.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@nt-nerdtechnic

Copy link
Copy Markdown
Collaborator Author

Squash-merged into main as e6ef5ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant