Repository navigation
fix(plugins): a local file's card no longer says it was not scanned beside its scan - #528
Closed
nt-nerdtechnic wants to merge 1 commit into
Closed
nt-nerdtechnic wants to merge 1 commit into
nt-nerdtechnic wants to merge 1 commit into
Conversation
…eside its scan Since 0.2.27 a plugin installed from a file gets Navide's own static scan, but its disclosure card still read "was not scanned by Navide" above a "What the publish-time scan found" section, a coverage line crediting the Navide Registry at publish, and "The scan was run by the Navide Registry". For local files only (localSource) the card now says Navide scanned the file on this computer and that the scan never decides the install, or that Navide did not scan it; the provenance line says Navide has not reviewed it. Marketplace cards render exactly as on main (main-baseline snapshot). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nt-nerdtechnic
marked this pull request as ready for review
October 20, 2026 22:37
nt-nerdtechnic
added a commit
that referenced
this pull request
Oct 20, 2026
…eside its scan (#528) Squash-merged from origin/pr-528. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Squash-merged into main as e6ef5ee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.2.27 checklist §10 (LOW, since ca47032): a plugin installed from a file now gets Navide's own static scan (W1,
pluginIpc.tslocalScan: 'ran'), but its disclosure card (install confirm dialogPluginTrustDialog, agent request cardPluginAgentRequestDialog, developer panel) still said:For
localSourceonly, the card now reads:zh-TW / ja-JP strings added alongside. Marketplace cards are unchanged: the existing
PluginDisclosureCard.main-baseline.htmlfile snapshot (verified card, listing card, no disclosure, with and without a marketplace source row) still matches byte for byte; the snapshot file is not touched.Not changed, for coordination:
PluginSourceBadgestill says "Not scanned (only Navide plugins installed from the Navide Marketplace are scanned by Navide)" for local sources. That component is being changed by another pane (修-0228-DX三個高, A1 gaps), so it is left to them; it has the same contradiction when the local scan ran.Test plan (red → green)
PluginDisclosureCard local file scan wordingtests (scanned / not scanned × wording, and no missing key in en-US, zh-TW, ja-JP).pnpm vitest run src/renderer/src/components/__tests__/PluginDisclosureCard.test.ts --maxWorkers=1 -t "local file scan wording"→ 2 failed, 3 passed.pnpm vitest runPluginDisclosureCard, PluginTrustDialog*, PluginAgentRequestDialog*, MarketplacePane*, ExtensionsPane*, MarketplaceDeveloperPanel* tests +packages/plugin-ui/src/foundation/i18n/__tests__/{glossary,locales}.test.ts,--maxWorkers=2→ 8 files, 220 passed.pnpm typecheck:web→ exit 0.Regression: existing plugins
Protection check
git diff origin/main..HEAD --stat -- 'backend/agent_team_backend/credential_*' 'backend/agent_team_backend/quota_*' 'backend/agent_team_backend/usage_*'→ empty; no account-switch code touched.scanKeykeeps its signature (readsprops.localSource). Locale keypluginDisclosure.provenance.localreworded; new keysscanHeadingLocal,scannedLocally,limitsWithoutScanLocal,scan.coverage.local,scan.noScanLocal.🤖 Generated with Claude Code