Repository navigation
refactor: share signal metrics between comparison and profile views - #260
Merged
O2sa merged 1 commit intoOct 21, 2026
Merged
Conversation
|
@abhinavrastogi2627 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
O2sa
approved these changes
Oct 21, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
✨ Thank you, @abhinavrastogi2627! Another great contribution merged! 🚀 We truly appreciate your continued support! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
Extract the ten shared signal metrics into a typed developer-feature helper and use it in both views. Preserve metric order, translation keys, zero values and missing-value fallbacks. Comparison-only language metrics remain unchanged.
Validation: 241 tests passed across 30 files, including English/Arabic labels, absent signals, incomplete cached signals and zero values. TypeScript, locale validation, full Prettier check and production build passed on Node 24. Lint passed with one existing image warning in the leaderboard test. The build exercised its database-unavailable fallback; no live database or GitHub profile requests were validated.
Additionally, at the time of submission of this PR: