Repository navigation
Fixes #259 - #261
Fixes #259#261
Conversation
|
@aryansinha1908 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
left a comment
There was a problem hiding this comment.
The CI validation is failing with Type 'string' is not assignable to type 'UrlObject | RouteImpl<string>' after switching to Next.js Link.
Could you please fix the href typing so it matches the project's typed routes? If the destination is a static internal route, use the route literal directly or preserve its literal type rather than widening it to string.
Please avoid using as any just to bypass the error. Once the Node 24.x validation passes, this should be ready for approval.
|
Could you please update the commit message to follow the repository's commit message conventions (Conventional Commits)? Please ensure it uses the appropriate type, with a clear, concise description of the change. Thanks! |
fe94c03 to
e58f7a7
Compare
Replace the plain anchor with Next.js Link for client-side navigation, type the methodology href as a Route to satisfy typedRoutes, and use theme-aware primary-foreground text color. Closes O2sa#259 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e58f7a7 to
9d4658c
Compare
|
🎊 Welcome, @aryansinha1908! Your first contribution has been merged! 🚀 Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving! |
Fixes #259
Additionally, at the time of submission of this PR: