Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimHashDeduplicateFilternormalizes Hamming distance bylen(bin(value)), which includes the0bprefix and omits leading zero bits. Use the configuredSimhash.fwidth so the same bit distance always produces the same similarity.With 8-bit fingerprints,
worldandqualitydiffer by one bit: their similarity is 0.875, but the old calculation returns 0.9 and removes one atbound=0.1. Conversely,helloandsevenare incorrectly retained together atbound=0.125because their leading zeros reduce the denominator.Add CPU regressions for 8/16/64/128-bit fingerprints, symmetry, identical/opposite values, and both text pairs through JSONL-backed storage using
input_keyand single-elementinput_keys.Validation (Python 3.12):
pytest -m "cpu or api" -q: 198 passed, 48 deselected.twine check --strictpasses for both.