Skip to content

Integration tests should use random ports #73

Open

Description

@EdHurtig

For the time being, the integration tests should use randomized ports for Logging and Commands. This will allow mutilple jobs to coexist without deadlocking each other.

In the future we will contain these jobs on the Jenkins server in individual docker containers, etc

Activity

  1. EdHurtig commented on Nov 12, 2017

    @EdHurtig
    MemberAuthor

    Related to #62

  2. self-assigned this
    on Nov 12, 2017
  3. shorstman commented on Nov 12, 2017

    @shorstman
    Member

    Is there a range of valid ports/any ports that shouldn't be tested?

  4. EdHurtig commented on Nov 13, 2017

    @EdHurtig
    MemberAuthor

    uh anything in the unprivileged port range (I think anything above 1024 IIRC) is fine. Probably best to restrict the range to something like 20,000 to 30,000 and check the random port before starting the test.

    All this logic of port selection can be done in ControllerTest.py

  5. EdHurtig commented on Nov 13, 2017

    @EdHurtig
    MemberAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions