Repository navigation
Fix sparse endianness warnings in TCP hijacking - #123
Open
randomizedcoder wants to merge 1 commit into
Open
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
* homa_skb_hijacked compared the __be16 urgent field with ntohs(HOMA_HIJACK_URGENT); use htons, matching homa_hijack_set_hdr (same value on every architecture, since the swap is symmetric). * Declare homa_common_hdr.checksum as __sum16, the type returned by tcp_v4_check/tcp_v6_check, instead of __be16. * Found with sparse -D__CHECK_ENDIAN__; clears all four warnings in homa_hijack.c/.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homa_skb_hijacked: compare the__be16urgent field withhtons(HOMA_HIJACK_URGENT)(wasntohs), matchinghoma_hijack_set_hdr. Same value on all architectures.homa_common_hdr.checksum:__sum16(whattcp_v4_check/tcp_v6_checkreturn) instead of__be16.Found with sparse
-D__CHECK_ENDIAN__; clears all 4 warnings in homa_hijack.c/.h.No test: annotation-only, no behaviour change. Unit tests: 862/862 pass.
🤖 Generated with Claude Code