Repository navigation
Use typed user pointers for msg_control and HOMAIOCINFO - #124
Open
randomizedcoder wants to merge 1 commit into
Open
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
* homa_sendmsg and homa_recvmsg cast msg->msg_control to void __user *; use msg->msg_control_user instead (homa_sendmsg already checks msg_control_is_user). This also drops a __force. * homa_ioc_info stored hinfo.rpc_info in a plain char * and cast it back for copy_to_user; make dst a char __user * set with u64_to_user_ptr. * No functional change. Found with sparse (-Wsparse-all: "cast adds address space '__user'"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msg->msg_control_userinstead of castingmsg->msg_control(sendmsg already checksmsg_control_is_user); drops one__force.char __user *dst = u64_to_user_ptr(hinfo.rpc_info)instead of a plainchar *cast back forcopy_to_user.Found with sparse
-Wsparse-all(4× "cast adds address space '__user'"); all four are gone.No test: no functional change. Unit tests: 862/862 pass.
🤖 Generated with Claude Code