Skip to content

Rename packages that have DHB in their names #62

Closed

Description

@olekscode

The following packages still have the DHB part in their names:

  • Math-DHB-Numerical
  • Math-Tests-DHB-Numerical
  • Math-Tests-DHB-wk

We should change DHB to PM.
However (!), it would be much better to come up with better names for these packages. At this moment the naming is very inconsistent. For example, the tests for PMMatrix are in package Math-Tests-Matrix and the tests for PMVector are in Math-Tests-DHB-Numerical.

Activity

  1. changed the title [-]Rename test packages that have DHB in their names[/-] [+]Rename packages that have DHB in their names[/+] on Jul 5, 2018
  2. SergeStinckwich commented on Jul 5, 2018

    @SergeStinckwich
    Member

    Or remove completely PM or DHB, because they have all a Math prefix.
    I agree with you about the inconsistent naming.
    What do you propose ?

  3. olekscode commented on Jul 5, 2018

    @olekscode
    MemberAuthor

    Is Math a good prefix?
    We will be prefixing all classes with PM, so maybe we can use the same prefix for packages?

    Of course, PM-Tests doesn't look as good as Math-Tests, but two different prefixes may confuse the users.

  4. olekscode commented on Jul 5, 2018

    @olekscode
    MemberAuthor

    I propose creating a file where we describe the style rules (brief style guide).
    Then we can post the link to in on the mailing list and Discord and discuss with everyone what could be the best naming conventions.

    This way we should redefine all names in PolyMath and make them consistent with each other.

    For example:
    Packages: PM-{Package}-{Name}
    Classes: PM{ClassName}
    Test packages: PM-Tests-{Name}
    Test classes: PM{Name}Tests

    Another big question is what should be the level of abstraction. Right now we have many packages which have just one class inside (especially test packages), and other packages that have so many classes that they could be split into multiple packages.

    I think it's a very difficult question, but probably we should start by defining the whole scope of applications of PolyMath. For example, "PolyMath is a library of numerical algorithms". Then split this area into subareas. Example: "Statistics", "Linear algebra", "Machine Learning", etc. (we can use the chapters of Numerical Methods book as a reference, but we need to update this classification because modern PolyMath is different from what it was back then). Then each group could be a package: PM-Statistics, PM-Linear-Algebra, PM-Machine-Learning. And then: PM-Tests-Statistics, PM-Tests-Linear-Algebra, PM-Tests-Machine-Learning.

    This is just an idea. I think that we need to discuss this with everyone and make a style guide.

  5. SergeStinckwich commented on Jul 8, 2018

    @SergeStinckwich
    Member

    I agree mostly with what you say, but I'm a reluctant to move all Math-XXX package to PM-XXX. First of all because it will need a lot of changes and then because if look at current packages names, most of the time there is not acronyms in package names. So for the moment, until we release 1.0, we can keep Math-XXX or rename with PolyMath-XXX.

  6. SergeStinckwich commented on Jul 8, 2018

    @SergeStinckwich
    Member

    yes the whole scope of PolyMath is a library of numerical algorithms and then we need to split in different meaningfull packages : PolyMath-Algebra, PolyMath-DataAnalysis, etc ...

  7. SergeStinckwich commented on Apr 30, 2019

    @SergeStinckwich
    Member

    There is no more package with DHB inside. What is only missing is classes without PM prefix.

  8. hemalvarambhia commented on Apr 30, 2019

    @hemalvarambhia
    Contributor

    @SergeStinckwich I'll get on to that.

  9. added 2 commits that reference this issue on May 1, 2019
  10. added 2 commits that reference this issue on May 1, 2019
    a168191
    7996265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions