Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
See all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
PolyMathOrg
PolyMath
Repository navigation
Code
Issues
58
(58)
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
More
items
[Issue 154] Refactor PMAccuracy testDataTree method
- #163
#163
Merged
SergeStinckwich
merged 13 commits into
master
PolyMathOrg/PolyMath:master
from
issue-154-refactor-tests
PolyMathOrg/PolyMath:issue-154-refactor-tests
Copy head branch name to clipboard
Jan 10, 2020
Conversation
Commits
13
(13)
Checks
Files changed
Merged
[Issue 154] Refactor PMAccuracy testDataTree method
#163
SergeStinckwich
merged 13 commits into
master
PolyMathOrg/PolyMath:master
from
issue-154-refactor-tests
PolyMathOrg/PolyMath:issue-154-refactor-tests
Copy head branch name to clipboard
Commits
Commits on Dec 27, 2019
[issue-154] Moved the test method to its own test case class so that we can break up the long test method and understand the message better.
hemalvarambhia
committed
2ad957b
View commit details
Copy full SHA for 2ad957b
Browse repository at this point
[issue-154] Moved some test code to an intention-revealing test method & identified a possible smell.
hemalvarambhia
committed
2f4a609
View commit details
Copy full SHA for 2f4a609
Browse repository at this point
[issue-154] Moved a block of code to its own intention-revealing test method.
hemalvarambhia
committed
4faff3d
View commit details
Copy full SHA for 4faff3d
Browse repository at this point
[issue-154] Moved some test code to its own intention-revealing method.
hemalvarambhia
committed
a0e214c
View commit details
Copy full SHA for a0e214c
Browse repository at this point
[issue-154] Added a smell comment to help the next developer.
hemalvarambhia
committed
b9d25e7
View commit details
Copy full SHA for b9d25e7
Browse repository at this point
[issue-154] Added more smells to the smell comment.
hemalvarambhia
committed
3d6b2de
View commit details
Copy full SHA for 3d6b2de
Browse repository at this point
[issue-154] Moved the test code to an intention-revealing test method, extracted the expected result to a role-revealing local variable.
hemalvarambhia
committed
4b7b5e2
View commit details
Copy full SHA for 4b7b5e2
Browse repository at this point
[issue-154] Extracted test code to its own intention-revealing test method, with a comment identifying a coincidence between expected outcome and a default I discovered in the initialize method.
hemalvarambhia
committed
666afa0
View commit details
Copy full SHA for 666afa0
Browse repository at this point
Commits on Dec 28, 2019
[issue-154] Added calls to the super class methods as required.
hemalvarambhia
committed
23ab70b
View commit details
Copy full SHA for 23ab70b
Browse repository at this point
[issue-154] Put the call to the super class method in the right place.
hemalvarambhia
committed
767ec74
View commit details
Copy full SHA for 767ec74
Browse repository at this point
[issue-154] Improved the name of the local variable. We still don't know the role it plays in the test yet so gave it a structural name.
hemalvarambhia
committed
51d5e6c
View commit details
Copy full SHA for 51d5e6c
Browse repository at this point
[issue-154] Improved the name of a local variable.
hemalvarambhia
committed
11b1b53
View commit details
Copy full SHA for 11b1b53
Browse repository at this point
[issue-154] Moved the test code to its own better named test method.
hemalvarambhia
committed
a4b6eb5
View commit details
Copy full SHA for a4b6eb5
Browse repository at this point
You can’t perform that action at this time.