Using PowershellStandard to determine dlls to import to script module? #71

Activity

1. TylerLeonhardt commented on Oct 14, 2019

   

   TylerLeonhardt

   on Oct 14, 2019

   Member

   More actions

   It's a good question but it has a complicated answer. Ideally what you would do is go through all the dlls that are sitting in $PSHOME and all the dlls in the publish directory of your module and exclude the ones that are already in $PSHOME however, this gets tricky because if you target multiple versions of PowerShell, the dll list might be different.

   A perfect example of this is Newtonsoft.dll which exists in PowerShell Core, but not in Windows PowerShell. If you want users to also use your module in Windows PowerShell, then you also need to bundle Newtonsoft.dll.

   Ideally, we'd have some tooling to help out with this scenario... but we haven't had the time to do so.
2. TylerLeonhardt

   added

   questionFurther information is requestedFurther information is requested

   on Oct 14, 2019
3. TylerLeonhardt commented on Oct 14, 2019

   

   TylerLeonhardt

   on Oct 14, 2019

   Member

   More actions

   cc Steve Lee (@SteveL-MSFT) James Truher (@JamesWTruher)
4. JustinGrote commented on Oct 14, 2019

   

   Justin Grote (JustinGrote)

   on Oct 14, 2019 via email

   Author

   More actions

   Thanks Tyler, I figured that was pretty much the story, my current plan was to do a dotnet build against the powershell library and get an inventory of assemblies, then compare that to the standard list and only grab the copies. This will work 90% of the time but there's a couple potential issues: 1. Libraries/Assemblies that got rolled into mscorlib or otherwise abstracted 2. Libraries with multiple versions, e.g. I need newtonsoft.json v10 but v6 is what comes with Powershell and it will only load one at a time. That's in another issue, and is solvable with bindings. If I come up with some half-decent tooling I will reference it here.

   …

   On Mon, Oct 14, 2019 at 11:20 AM Tyler James Leonhardt < ***@***.***> wrote: It's a good question but it has a complicated answer. Ideally what you would do is go through all the dlls that are sitting in $PSHOME and all the dlls in the publish directory of your module and exclude the ones that are already in $PSHOME however, this gets tricky because if you target multiple versions of PowerShell, the dll list might be different. A perfect example of this is Newtonsoft.dll which exists in PowerShell Core, but not in Windows PowerShell. If you want users to also use your module in Windows PowerShell, then you also need to bundle Newtonsoft.dll. Ideally, we'd have some tooling to help out with this scenario... but we haven't had the time to do so. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#71?email_source=notifications&email_token=ADUNKUWR6VGRGEJ2JADTCK3QOSZ5RA5CNFSM4JASFPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBF4V4I#issuecomment-541838065>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUNKUUPBUA3RAS3DZYETLTQOSZ5RANCNFSM4JASFPMQ> .

   👍React with 👍1Reacted by TylerLeonhardt
5. JustinGrote commented on Oct 15, 2019

   

   Justin Grote (JustinGrote)

   on Oct 15, 2019

   Author

   More actions

   TylerLeonhardt I made a pretty effective tool for this! It basically builds an empty dotnet project against the powershell standard with packagereferences to the required nuget packages, then copies over the DLLs.

   https://gist.github.com/JustinGrote/5daa3d02be2ff9e913ae6b2a0f96769b

   Todo still: Detect and resolve with assembly binding redirects if an older assembly exists natively. What I've run into most commonly: System.Runtime.CompilerServices.Unsafe

   🎉React with 🎉1Reacted by Steve Lee
6. JustinGrote commented on Apr 1, 2020

   

   Justin Grote (JustinGrote)

   on Apr 1, 2020

   Author

   More actions

   I would say this is still something that PowershellStandard should cover, as teams such as PSGet do not appear to be leveraging it and still using manual methods to pare down the assembly list
   https://github.com/PowerShell/PowerShellGet/issues/104#issuecomment-607433179