Repository navigation
fix(deps): pin patched markdown-it - #394
Conversation
Raise the markdown-it override floor to 14.3.3 to clear GHSA-vfgh-jcmw-g37q. The lockfile is a web build input, so the web bundle is restaged and the Nix dependency hash is refreshed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
commit: |
Requirement or Bug
pnpm audit(the required Security audit check) fails onmainand on every open PR because of GHSA-vfgh-jcmw-g37q (markdown-it, quadratic-time denial of service, published 2026-10-20).Bug Reproduction Steps
main.pnpm audit. It reports markdown-it 14.3.2 (<14.3.3) throughapps/vscode > @vscode/vsce > markdown-itand exits non-zero.Root Cause
The root override
"markdown-it": ">=14.3.1 <15"lets the lockfile keep 14.3.2, which is inside the affected range.Code Changes
pnpm-lock.yamlregenerated with pnpm: markdown-it 14.3.3.apps/pythinker-code/dist-webis restaged withpnpm run build:web.flake.nixpnpmDeps hash refreshed.No new dependencies.
Behavior Changes and Affected Users
Local checks:
pnpm auditexits 0,check-web-assetsOK,nix build .#pythinker-codepasses. [skip changeset] Users cannot see this change: it moves a packaging tool dependency to a patch release.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Summary by CodeRabbit