Skip to content

Fix #113 - #357

Merged
jmadler merged 2 commits into
PythonCharmers:masterfrom
flaviut:master
Sep 10, 2018
Merged

jmadler merged 2 commits into
PythonCharmers:masterfrom
flaviut:master

Conversation

@flaviut

@flaviut flaviut commented Sep 3, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@jmadler

jmadler commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Would you be comfortable adding a unit test for this?

@flaviut

flaviut commented Sep 7, 2018

Copy link
Copy Markdown
Contributor Author

Sure, just give me a few moments. Do you know what's going on with this project? There haven't been any updates in a while.

@jmadler

jmadler commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Thanks!

I spoke with @edschofield yesterday and I'm going to help him maintain python-future going forward. We're using it heavily at Pinterest at the moment and we have a few bugs we've discovered and patches we'd like to share upstream :)

@jmadler

jmadler commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Perfect! Thank you so much :)

@jmadler
jmadler merged commit 7499e98 into PythonCharmers:master Sep 10, 2018
@flaviut

flaviut commented Sep 10, 2018

Copy link
Copy Markdown
Contributor Author

Oh, sorry, I should have marked it WIP!

I noticed that a couple of the other tests failed with this change, and I haven't figured out why yet. Can you please revert this?

@flaviut

flaviut commented Sep 10, 2018

Copy link
Copy Markdown
Contributor Author

Can you please take a look at #361? It fixes the regression that this PR introduced, and is a 1-line change.

jmadler added a commit that referenced this pull request Sep 10, 2018
@jmadler

jmadler commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Will do, thanks. I assumed the test failures were a result of the known issues with 3.5+, but that was clearly in error. Great eye :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants