Skip to content

Fix: improve csv seed file type inference #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
Apr 9, 2024
Merged

Fix: improve csv seed file type inference #2418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlmesh/core/model/definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ def render(
for column in date_columns:
df[column] = df[column].dt.date
df[bool_columns] = df[bool_columns].apply(lambda i: str_to_bool(str(i)))
df[string_columns] = df[string_columns].mask(
df.loc[:, string_columns] = df[string_columns].mask(
cond=lambda x: x.notna(), other=df[string_columns].astype(str) # type: ignore
)
yield df
Expand Down
1 change: 1 addition & 0 deletions sqlmesh/core/model/seed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def _get_df(self) -> pd.DataFrame:
StringIO(self.content),
index_col=False,
on_bad_lines="error",
low_memory=False,
**{k: v for k, v in self.settings.dict().items() if v is not None},
)
self._df = self._df.rename(
Expand Down
2 changes: 1 addition & 1 deletion web/server/watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ async def watch_project() -> None:
]
ignore_entity_patterns = context.config.ignore_patterns if context else c.IGNORE_PATTERNS
ignore_entity_patterns.append("^\\.DS_Store$")
ignore_entity_patterns.append("^.*\.db(\.wal)?$")
ignore_entity_patterns.append("^.*\\.db(\\.wal)?$")
ignore_paths = [str((settings.project_path / c.CACHE).resolve())]
watch_filter = DefaultFilter(
ignore_paths=ignore_paths, ignore_entity_patterns=ignore_entity_patterns
Expand Down