Repository navigation
Conversation
`instructions` and `check` now generate the instructions, copy them or write them to a file, and print them or confirm the delivery as three separate steps. The JSON output of both commands will include the instructions instead of printing them, and reuse the first two steps. The text output doesn't change.
`--json` prints the instructions, whether they were also copied to the clipboard, the app they are for, and its results directory. That directory may not exist yet: the instructions start by running `check`, which creates it. With `--write`, stdout holds only the written file's path and format, as for `doc fetch`. The instructions' JSON definition is shared, so that `check` can include it in its result as well.
A failed copy of the app security check instructions surfaced as an unexpected error, reported as a bug with its stack. It now aborts with the `clipboard-unavailable` code and the clipboard tool's message, and suggests printing the instructions or writing them to a file instead. `check` copies through the same step, so it aborts the same way.
jek
added this pull request to stack #8969
October 21, 2026 00:00
app security instructions
jek
marked this pull request as ready for review
October 21, 2026 13:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
app security instructionsprints the coding-agent workflow as Markdown, or copies or writes it. Callers using--jsonneed the instructions inside a single result, andcheck(later in this stack) will return them the same way.WHAT is this pull request doing?
Adds
--jsontoapp security instructions:{"status": "success", "app": {…}, "resultsDirectory": "…", "instructions": {"content": "<Markdown>", "copied": false}}. With--copy,copiedistrue. The results directory may not exist yet, because the instructions start by runningcheck.--write <file>, stdout holds only{"path": "/abs/file.md", "format": "markdown"}, as withdoc fetch.Commits:
checkcan reuse them. No behaviour change.--json.xselon Linux, for example),--copyused to fail as an unexpected error with a stack trace, reported as a bug. It now fails as an error with the codeclipboard-unavailableand suggests printing or--writeinstead. It has its own patch changeset.How to manually test your changes?
Build once and run the local CLI directly, so nothing else reaches stdout:
To see the clipboard error on macOS, hide
pbcopy, then run--copywith and without--json:Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add