refactor(examples/angular/basic): make the 'postId' input required and remove the always-true 'enabled' in 'PostComponent' by sukvvon · Pull Request #12170 · TanStack/query

sukvvon · 2026-10-20T01:53:05Z

🎯 Changes

PostComponent declared postId = input(0) and guarded the query with enabled: this.postId() > 0, but the app only renders it with a post id, and post ids start at 1, so the guard was always true. Make postId a required input and remove the enabled option.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Post details now require a valid post ID before loading, preventing queries from running with an unintended default ID.

…d remove the always-true 'enabled' in 'PostComponent'

changeset-bot · 2026-10-20T01:53:10Z

⚠️ No Changeset found

Latest commit: f4f7120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-20T01:53:32Z

View your CI Pipeline Execution ↗ for commit f4f7120

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 54s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 02:04:36 UTC

github-actions · 2026-10-20T01:53:59Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-10-20T01:55:07Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12170

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12170

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12170

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12170

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12170

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12170

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12170

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12170

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12170

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12170

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12170

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12170

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12170

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12170

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12170

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12170

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12170

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12170

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12170

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12170

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12170

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12170

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12170

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12170

commit: f4f7120

github-actions · 2026-10-20T01:55:13Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

coderabbitai · 2026-10-20T01:57:08Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: fb1dfa5d-321f-43b1-ad25-36d60c681b3e

📥 Commits

Reviewing files that changed from the base of the PR and between 8c8599f and f4f7120.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 26b3bf4e-c069-45d2-8415-cbd6f1045217

📥 Commits

Reviewing files that changed from the base of the PR and between 2fb9d90 and 8c8599f.

📒 Files selected for processing: 1

examples/angular/basic/src/app/components/post.component.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The Angular post component now requires a numeric postId input. Its query configuration no longer checks whether the ID is greater than zero before enabling the query.

Changes: Post query input

Layer / File(s)	Summary
Require post ID `examples/angular/basic/src/app/components/post.component.ts`	`postId` uses a required numeric input instead of defaulting to `0`. The query's `enabled` condition was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Suggested reviewers: arnoud-dv

Merge Risk: ⚪ Minimal · up to 8c859

No actionable merge-blocking risk remains in this example-only input change.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly describes the main change: making the Angular example's postId input required and removing the redundant enabled option.
Description check		The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, records testing and policy checks, and identifies the change as dev-only with no rele…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, records testing and policy checks, and identifies the change as dev-only with no release impact.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

refactor(examples/angular/basic): make the 'postId' input required an…

8c8599f

…d remove the always-true 'enabled' in 'PostComponent'

sukvvon self-assigned this Oct 20, 2026

Merge branch 'main' into refactor/angular-basic-required-post-id

f4f7120

Navigation Menu

Repository navigation

refactor(examples/angular/basic): make the 'postId' input required and remove the always-true 'enabled' in 'PostComponent' - #12170

refactor(examples/angular/basic): make the 'postId' input required and remove the always-true 'enabled' in 'PostComponent'#12170
sukvvon wants to merge 2 commits into
mainfrom
refactor/angular-basic-required-post-id

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Review skipped

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

size-limit report 📦

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading